Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO NEW TESTS NEEDED] Refactor podman container command output #12460

Merged
merged 1 commit into from
Dec 1, 2021
Merged

[NO NEW TESTS NEEDED] Refactor podman container command output #12460

merged 1 commit into from
Dec 1, 2021
+35 −48

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Nov 30, 2021

Leverage new report.Formatter allowing better compatibility from
podman command output.

See #10974
See #12455

Depends on containers/common#831

Signed-off-by: Jhon Honce [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2021
@jwhonce jwhonce requested a review from ashley-cui November 30, 2021 22:39
@jwhonce jwhonce self-assigned this Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@jwhonce
[NO NEW TESTS NEEDED] Refactor podman container command output
db3a4c0 
Leverage new report.Formatter allowing better compatibility from
podman command output.

See containers#10974
See containers#12455

Depends on containers/common#831

Signed-off-by: Jhon Honce <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2021

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

@ashley-cui WDYT?

ashley-cui
ashley-cui reviewed Dec 1, 2021
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1422cdb into containers:main Dec 1, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwhonce @rhatdan @TomSweeneyRedHat @ashley-cui @openshift-merge-robot